WIFI Failure #25
Merged
WIFI Failure #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The firmware halts when it loses the wifi connection.
johncarl-te
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Only suggestion going forward is to be a bit more clear with your commit message. A good commit message title should be in the "imperitive" mood. In this case it should be something like "Call esp_restart on connection failure". A good way to think about it is say "This change will..." in your head and the following words should be your commit title.
The body of the commit message should include a longer explanation which in this case can include the issue that is solved by this fix.
|
thanks for the advice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The firmware halts when it loses the wifi connection.