Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries if the stratum hostname is not found #27

Closed
wants to merge 2 commits into from

Conversation

SatsForFreedom
Copy link
Contributor

After restoring the Wi-Fi connection, the router may still try to connect to the internet. Therefore, it will fail to solve the IP address, and then the *ipaddr returns a NULL pointer.

After restoring the Wi-Fi connection, the router may still try to connect to the internet. Therefore, it will fail to solve the IP address, and then the *ipaddr returns a NULL pointer.
After restoring the Wi-Fi connection, the router may still try to connect to the internet. Therefore, it will fail to solve the IP address, and then the *ipaddr returns a NULL pointer.
Copy link
Collaborator

@johnny9 johnny9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash your commits and be more clear with the title. Advice is to use "imperative mood". Basically finish the sentance "This change will...". Something like "add retries if the stratum hostname is not found"

@SatsForFreedom SatsForFreedom changed the title dns_found_cb bug Fix Add retries if the stratum hostname is not found Sep 5, 2023
@johnny9
Copy link
Collaborator

johnny9 commented Sep 5, 2023

Squash your commits with git rebase -i origin/master

@SatsForFreedom
Copy link
Contributor Author

I find another issue in my commit. I will push a fix later

@SatsForFreedom SatsForFreedom deleted the patch-3 branch September 7, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants