Add retries if the stratum hostname is not found #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why was bDNSFound changed from a bool to an int? |
SatsForFreedom
force-pushed
the
master
branch
from
d8d5a8b
to
8b296d6
Compare
|
Because I need 3 states: waiting, success and failure. |
johnny9
requested changes
Sep 10, 2023
main/tasks/stratum_task.c
Outdated
| @@ -18,7 +18,7 @@ | |||
|
|
|||
| static const char *TAG = "stratum_task"; | |||
| static ip_addr_t ip_Addr; | |||
| static bool bDNSFound = false; | |||
| static int8_t bDNSFound = 0; | |||
There was a problem hiding this comment.
this variable is no longer a bool, give it a clearer name and use an enum for the different states or have a second bool for tracking dns progress
components/bm1397/bm1366.c
Outdated
| @@ -704,6 +704,11 @@ task_result *BM1366_proccess_work(void *pvParameters) | |||
|
|
|||
| GlobalState *GLOBAL_STATE = (GlobalState *)pvParameters; | |||
|
|
|||
| if (GLOBAL_STATE->valid_jobs[rx_job_id] == 0) { | |||
There was a problem hiding this comment.
I merged this piece already. Can you update the PR without it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After restoring the Wi-Fi connection due to a power outage, the router may still try to connect to the internet. Therefore, it will fail to solve the IP address, and then the *ipaddr returns a NULL pointer. This will crash the firmware when it reads from a NULL pointer.