http_server: Add a way to set raw NVS parameters #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be under it's own rest endpoint rather than reusing the existing one |
|
Why? What if a user wants to change a normal one at the same time? |
|
This is best practice for designing RESTful interfaces and maintaining a single responsibility for a given resource. I suggest putting this under PATCH /api/system/raw |
luke-jr
force-pushed
the
http_raw_nvs
branch
2 times, most recently
from
6738426
to
6c56b02
Compare
|
Ok, how's this? |
|
I'd like to address #385 first. |
luke-jr
force-pushed
the
http_raw_nvs
branch
2 times, most recently
from
be7c76f
to
273c8de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.