Fix polling loop death on getInfo error #737
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutatrum
changed the title
mutatrum
force-pushed
the
fix-polling-loop-death
branch
from
e39c607 to
6dea644
Compare
|
I have trouble testing this as my Bitaxe is getting a new IP address on every reboot and I don't have access to my router to give it a fixed IP address. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The polling loop of
getInfoon the dashboard and the logs screen dies if the call returns an error, or is unavailable.I tried fixing it, but not sure if it works as intended. One solution is mapping error objects to a DEFAULT_SYSTEM_INFO, and add an
errorfield. That's the current implementation. It seems to work, however, theconsole.logdoes not show up. The dashboard does continue polling, so at least that's that. The error part should probably be shown in a toast or something, but I'm out of my depth here.The alternative is the
filtercall, this should exit the loop completely. However, this would not give any feedback back to the user.The deleted lines at home.component.ts#L58-59 are unrelated, this just fixes a console error. We no longer have 3 datasets.