Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds deepStrictEqual to Chai Assert list #337

Merged
merged 2 commits into from
Aug 1, 2022

Conversation

abnersajr
Copy link
Contributor

@abnersajr abnersajr commented Jul 20, 2022

Even though Chai docs doesn't display the use of deepStrictEqual. It is a valid assertion and follows the assert model.

This PR adds the transform equivalent for jest.

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #337 (57f17c2) into main (640e3d4) will not change coverage.
The diff coverage is n/a.

❗ Current head 57f17c2 differs from pull request most recent head 484d065. Consider uploading reports for the commit 484d065 to get more accurate results

@@           Coverage Diff           @@
##             main     #337   +/-   ##
=======================================
  Coverage   92.09%   92.09%           
=======================================
  Files          26       26           
  Lines        1872     1872           
  Branches      393      393           
=======================================
  Hits         1724     1724           
  Misses        102      102           
  Partials       46       46           
Impacted Files Coverage Δ
src/transformers/chai-assert.ts 99.21% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 640e3d4...484d065. Read the comment docs.

Copy link
Owner

@skovhus skovhus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@skovhus skovhus enabled auto-merge (squash) August 1, 2022 20:09
@skovhus skovhus merged commit 2ef426c into skovhus:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants