[sinon] implement on{,First,Second,Third}Call([...])

[danbeam]

Reviewers (other than @skovhus): @catc @lencioni @jayrobin

[codecov]

Codecov Report

Merging #361 (e1f57d6) into main (6128a21) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
+ Coverage   92.19%   92.30%   +0.11%     
==========================================
  Files          26       26              
  Lines        1896     1924      +28     
  Branches      398      404       +6     
==========================================
+ Hits         1748     1776      +28     
  Misses        102      102              
  Partials       46       46              

Impacted Files	Coverage Δ
src/transformers/sinon.ts	89.92% <100.00%> (+1.17%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[skovhus]

Personally I find one-line statements less readable and error prone.

It would be slightly nicer with an arrow function here.

[danbeam]

hey @skovhus, I'm not sure I understand what you're asking for here.

do you mean braces around the if?

      stub.mockImplementation(() => {
            if (stub.mock.calls.length === 2) {
                  return [8, 9, 10];
            }

you said "arrow function" so maybe you mean this?

      stub.mockImplementation(() => stub.mock.calls.length === 2 && [8, 9, 10]);

[danbeam]

because the second route (stub.mockImplementation(() => stub.mock.calls.length === 2 && [8, 9, 10]);) would sometimes produce false for a return value (which differs from sinon)

const sinon = require('sinon');

const s = sinon.stub();

s.onFirstCall().returns(5);

console.log(s());  // 5
console.log(s());  // undefined

i went with braces around the single-line if statements. hopefully that's what you meant.

[skovhus]

Yes I would prefer us to either use block statements or arrow functions instead of the one-line statements. Thanks for fixing this.