Sinon: add support for transforming callsFake #500
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
When running the codemods on a quite large test suite, I noticed that
sinon.stub(obj, 'prop').callsFake(fn)
does not seem to be transformed. Docs: https://sinonjs.org/releases/latest/stubs/#propertiesI changed it so, that
will be turned into
which should be the expected result.
I also added a couple of additional test cases to verify that
sinon.stub()
without arguments is transformed correctly (no changes in the code were needed).ping @skovhus