fix: resolve Prettier config based on generated file #225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Resolves #219.
Recent versions of Prettier have changed the logic for resolving the config. This line appears to be the culprit:
When
attemptPrettier
is called, it passesprocess.cwd()
as the "file" in the snippet above. It's common fortyped-scss-modules
to be executed from the project root, so the config search starts outside the project root and doesn't find anything.What?
attemptPrettier
resolves the prettier config based on the generated file path instead ofprocess.cwd()
.