fix(export-default): export a type instead of an interface Fixes #71 #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y#71 Before we were unable to do this: ```typescript export interface Styles { 'classname--first': string; 'classname--second': string; } function foo(bar: Record<string, string>){ return Object.keys(bar); } ``` Because an interface does not allow being cast as a wider type. This fixes that by using types instead of interfaces: ```typescript export type Styles = { 'classname--first': string; 'classname--second': string; } ``` BREAKING CHANGE: this can interfere with how others use their default exported classnames
|
@nperez0111 overall this looks great! Thanks for fixing all of the typos as well. Not sure if this was ready for review or not, but I'll take another look after you have the chance to fix the failing tests 👍 |
|
Thanks for mentioning the tests, are fixed now! |
skovy
approved these changes
Jul 6, 2020
|
@all-contributors please add @nperez0111 for bug and code |
|
I've put up a pull request to add @nperez0111! 🎉 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rel: #71
Before we were unable to do this:
Because an interface does not allow being cast as a wider type. This fixes that by using types instead of interfaces:
BREAKING CHANGE: this can interfere with how others use their default exported classnames
PS: added some typo fixes in as well