Fixed scrolling when QuickLook is opened in Elements panel #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lows running sketch-dev-tools on an older mac. this might gonna be reverted
- show `QuickLook` when `selectedElement` equals to current element id
|
haven't reviewed yet but there were some discussion about transpiling |
|
Yeah, saw that, but at least I can run it instead of erroring during start. In my own plugin with webview I had to use a safer version https://github.com/atlassian/cocoascript-class for proper transpiling. It's totally fine to exclude |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So basically this fixes #18. If you can review this, this will be great.
ElementTreeItemWrapperwas required, becauseElementTreeItemis rendered recursively.This is 100% going to be rebased I think, as PR also includes change to
webpack.skpm.config.jsthat was required to get dev tools running on older mac, but most probably you want this to be reverted.