Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logback to 1.3.11 and log4jOverSlf4j to 2.0.7 #229

Merged

Conversation

BarbieCue
Copy link
Contributor

My IDE powered code scan reports a vulnerable transitive dependency when using skrapeit.

image

For skrapeit:1.3.0-alpha.1 but also for older versions. A look behind the scenes shows that logback can be easily updated, which should prevent this circumstance.

Logback News: https://logback.qos.ch/news.html

To avoid vulnerable transitive dependency
maven:ch.qos.logback:logback-core:1.2.3
(CVE-2021-42550)
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #229 (fc3d226) into master (408f8e2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #229   +/-   ##
=======================================
  Coverage   81.05%   81.05%           
=======================================
  Files          39       39           
  Lines        1171     1171           
  Branches      180      180           
=======================================
  Hits          949      949           
  Misses        161      161           
  Partials       61       61           

@christian-draeger christian-draeger merged commit 4926f42 into skrapeit:master Aug 18, 2023
5 checks passed
@BarbieCue BarbieCue deleted the update-logback-und-log4jOverSlf4j branch August 19, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants