Skip to content

Commit

Permalink
conformance: fixes for invalid reference policy test
Browse files Browse the repository at this point in the history
- fixes path prefix match YAML
- removes check for HTTPRoute to be Accepted pending kubernetes-sigs#1112

Signed-off-by: Steve Kriss <krisss@vmware.com>
  • Loading branch information
skriss committed May 20, 2022
1 parent c7fe7e4 commit 903eeb2
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
6 changes: 3 additions & 3 deletions conformance/tests/httproute-invalid-reference-policy.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,12 @@ var HTTPRouteInvalidReferencePolicy = suite.ConformanceTest{
kubernetes.HTTPRouteMustHaveParents(t, s.Client, routeNN, parents, false, 60)
})

// TODO(mikemorris): Un-skip check for Listener ResolvedRefs
// TODO(mikemorris): Un-comment check for Listener ResolvedRefs
// RefNotPermitted condition and/or add check for attached
// routes and any expected Listener conditions once
// https://github.com/kubernetes-sigs/gateway-api/issues/1112
// has been resolved
// t.Skip("Gateway listener should have a ResolvedRefs condition with status False and reason RefNotPermitted", func(t *testing.T) {
// t.Run("Gateway listener should have a ResolvedRefs condition with status False and reason RefNotPermitted", func(t *testing.T) {
// listeners := []v1alpha2.ListenerStatus{{
// Name: v1alpha2.SectionName("http"),
// SupportedKinds: []v1alpha2.RouteGroupKind{{
Expand All @@ -90,7 +90,7 @@ var HTTPRouteInvalidReferencePolicy = suite.ConformanceTest{
// kubernetes.GatewayStatusMustHaveListeners(t, s.Client, gwNN, listeners, 60)
// })

gwAddr := kubernetes.GatewayAndHTTPRoutesMustBeReady(t, s.Client, s.ControllerName, gwNN, routeNN)
gwAddr := kubernetes.GatewayAndHTTPRoutesMustBeReady(t, s.Client, s.ControllerName, gwNN)

// TODO(mikemorris): Add check for HTTP requests successfully reaching
// app-backend-v1 at path "/" if it is determined that a Route with at
Expand Down
3 changes: 2 additions & 1 deletion conformance/tests/httproute-invalid-reference-policy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ spec:
rules:
- matches:
- path:
value: "/v2"
type: PathPrefix
value: "/v2"
backendRefs:
- name: app-backend-v2
namespace: gateway-conformance-app-backend
Expand Down

0 comments on commit 903eeb2

Please sign in to comment.