-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Feature: Support for Netatmo's Air Quality Monitor #52
Conversation
Sorry for the late response. Because I cannot test this I will merge this and prepare a new release for this. |
Hi @skrollme I can add a mock api (for tests) and there’s also a bit of documentation on the new configuration keys that needs to be added. |
Would be great if you could add some information about the config-values to the readme. Concerning testing: I meant I do not have this device at home so I cannot make "real life" tests. I believe / hope you have tested it with your device and/or mock-data ;) |
I’ll add some screenshots of it supporting the device, update the README with the new configs and add mock api data to the PR (I have it running for a few weeks now with a real device and everything works 👍 - will get screenshots as I mentioned) |
Hi @skrollme Just pushed a new commit with the relevant updates to README.md and mock api calls Also a screenshot of the current version working with Eve.app And with Home.app |
Thank you for your work, @foliveira . I'm really appreciate it. It feels like rarity (at least in my projects) that there are people who really contribute instead of just writing "that does not work" or "I want that!" I just merged your work and prepared everything for the npm release. 0.6.0 should be published soon |
Thanks @skrollme - I had already written a module to support this device, so it made perfect sense to rework that and integrate into this project. Feel free to ping me if any questions/bugs come up with this (hopefully that doesn’t happen 😅) |
I just added a default value for the weatherstation config-value (see https://github.com/skrollme/homebridge-eveatmo/blob/master/index.js#L19) because otherwise the weatherstation accessories would disappear for all user which would just update without changing their config. |
Good point. Since I use config-ui-x and don’t own a Weatherstation that one fell through; not having it for the AirQuality monitor should be fine as it is disabled by default, am I right in assuming that? |
That is correct 👌 |
This pull request adds support for Netatmo's Air Quality Monitor - also known as HomeCoach.
It's based on the Smart Home Station already supported by this module and can be toggled on/off with the module's config (default state is off).
NPM module
netatmo
already supports the call for the correct API calls withgetHealthyHomeCoachData()
, which then proceeds to populate a Eve Home like device supported by Homebridge. Supports Noise data, that can be checked with an alternative app like Eve Home.