This repository has been archived by the owner on Sep 4, 2024. It is now read-only.
rerun failed builds instead of using their cached result #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agis
suggested changes
Apr 27, 2018
cmd/mistryd/end_to_end_test.go
Outdated
| @@ -176,28 +176,57 @@ func TestResultCache(t *testing.T) { | |||
|
|
|||
| func TestResultCacheExitCode(t *testing.T) { | |||
There was a problem hiding this comment.
Does this test case makes sense at all after this change?
cmd/mistryd/end_to_end_test.go
Outdated
| t.Fatal(err) | ||
| } | ||
|
|
||
| assertNotEq(br.ExitCode, 0, t) |
There was a problem hiding this comment.
Why the exit code is 0 here? Shouldn't it be 33?
There was a problem hiding this comment.
we're testing whether the result was cached. a result is now only cached with an exit code of 0. so the test case now needs an exit code of 0
There was a problem hiding this comment.
i see we have another test for that actually, so I'm going to remove this one
|
LGTM 👏 |
|
Oh, please add an entry in the changelog (under |
dtheodor
force-pushed
the
rerun-failed-builds
branch
from
5aa037f to
3cf7f75
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-run "ready" jobs whose exit status is not 0. Re-running such a job means removing the existing ready folder and then proceeding as usual, i.e. creating a new pending folder etc.
Closes #45