#223 support webp binary in multiple os at once #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SightStudio
changed the title
sksamuel
reviewed
Apr 25, 2021
| } | ||
|
|
||
| return new String[] { | ||
| "/webp_binaries/" + os + "/" + binaryName, |
There was a problem hiding this comment.
Do we need to include the OS in the target path, since you're not going to have more than one installed at a time? And this way it would rename backwards compatible ?
There was a problem hiding this comment.
i misunderstood. it definitly does have backward compatilbity issue.
loading webp binary by environment variable looks better.
|
I think having the binaries in the dist/os/ folder is good.
But when we copy it, it can just go into /webp_binaries/binary
because you will never copy more than 1 per computer.
…On Sat, 24 Apr 2021 at 23:09, Dong Min Seol ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In scrimage-webp/src/main/java/com/sksamuel/scrimage/webp/WebpHandler.java
<#225 (comment)>:
> @@ -32,6 +32,21 @@ protected static void installBinary(Path output, String... sources) throws IOExc
throw new IOException("Could not locate webp binary at " + Arrays.toString(sources));
}
+ protected static String[] getBinaryPath(String binaryName) {
+ String os = "linux";
+
+ if(SystemUtils.IS_OS_WINDOWS) {
+ os = "window";
+ } else if(SystemUtils.IS_OS_MAC) {
+ os = "mac";
+ }
+
+ return new String[] {
+ "/webp_binaries/" + os + "/" + binaryName,
i think i misunderstood. it definitly does have backward compatilbity
issue.
loading webp binary as environment variable looks better.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#225 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFVSGT7XBWJ4NB6SFAYLDDTKOIV5ANCNFSM43MWXSFA>
.
|
|
ok then i'll add Did I get it right? |
|
Looks good! |
|
oh sorry for my mistake i'll fix test codes |
|
Cool, will need to be a new PR since I merged this one :) |
|
thanks i just created new one. #227 |
sksamuel
pushed a commit
that referenced
this pull request
Apr 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#223
i added platform specific subdirectory for webp binary (default is linux) with default embedeed binaries for each os
since i can't find out the version of pre-exisisting linux webp binaries,
i chaged all binareis to latest version (1.20)
this is off topic, but converting animated gif to animated webp requires
gif2webpwhich scrimage does not implemented
so i document it either.