Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

自作のclippy actionをCIに追加 #198

Merged
merged 1 commit into from
Dec 20, 2021
Merged

自作のclippy actionをCIに追加 #198

merged 1 commit into from
Dec 20, 2021

Conversation

sksat
Copy link
Owner

@sksat sksat commented Dec 20, 2021

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@sksat sksat force-pushed the add-my-clippy-action branch from 7e378df to 6e08e92 Compare December 20, 2021 22:23
@sksat
Copy link
Owner Author

sksat commented Dec 20, 2021

一旦 7bf76e5 をrevertすればdeprecatedが出るかな

@sksat
Copy link
Owner Author

sksat commented Dec 20, 2021

DockerHubへのloginがコケとるけど何?

src/main.rs Outdated
@@ -100,7 +100,7 @@
HttpServer::new(move || {
App::new()
.wrap(middleware::Logger::default())
.app_data(web::Data::new(data.clone()))
.data(data.clone())

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [clippy] reported by reviewdog 🐶
use of deprecated associated function actix_web::App::<T>::data: Use .app_data(Data::new(val)) instead.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よっしゃ

@sksat
Copy link
Owner Author

sksat commented Dec 20, 2021

revert commitを削除

@sksat sksat force-pushed the add-my-clippy-action branch from 14bdef3 to 6e08e92 Compare December 20, 2021 22:28
@sksat
Copy link
Owner Author

sksat commented Dec 20, 2021

OK

@sksat sksat merged commit ee9be17 into master Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant