Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] ensure deep_equals does not make any costly str coercions #213

Closed
fkiraly opened this issue Aug 4, 2023 · 0 comments · Fixed by #237
Closed

[ENH] ensure deep_equals does not make any costly str coercions #213

fkiraly opened this issue Aug 4, 2023 · 0 comments · Fixed by #237
Labels
feature request New feature or request good first issue Good for newcomers

Comments

@fkiraly
Copy link
Contributor

fkiraly commented Aug 4, 2023 •
edited
Loading

Profiling in sktime has unveiled that deep_equals made some unnecessary, costly str coercions of pandas objects.

In sktime the fix is here: sktime/sktime#5028

The same fix (or a similar one) should be applied to the skbase-native deep_equals.
@fkiraly fkiraly added feature request New feature or request good first issue Good for newcomers labels Aug 4, 2023
@fkiraly fkiraly mentioned this issue Oct 15, 2023
Merged
fkiraly added a commit that referenced this issue Oct 16, 2023
@fkiraly
[ENH] refactor string coercions and return logic in deep_equals uti…
8a517d7 
…lity (#237)

This PR refactors string coercions and return logic in `deep_equals`
utility, along the lines of sktime/sktime#5028.

Fixes #213.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ENH] refactor string coercions and return logic in deep_equals utility sktime/skbase
1 participant
@fkiraly