Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] python 3.13 compatibility #367

Closed
fkiraly opened this issue Sep 29, 2024 · 4 comments
Closed

[MNT] python 3.13 compatibility #367

fkiraly opened this issue Sep 29, 2024 · 4 comments
Labels
maintenance Continuous integration, unit testing & package distribution

Comments

@fkiraly
Copy link
Contributor

fkiraly commented Sep 29, 2024 •
edited
Loading

We need to release a python 3.13 compatible version once 3.13 is released.

Overall strategy with sktime: sktime/sktime#7190

For skbase, we should:

  1. release experimental 3.13 wheels for reverse dependencies to test on
  2. once 3.13 is released, full wheels

The PR #365 adds testing on 3.13 rc2.
The testing uses sklearn, which seems incompatible with 3.13 on windows.

For now, windows testing is skipped, but that should also be reverted.

Todos:

  • change testing to test with 3.13 release version
  • add 3.13 tests to release workflow
@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Sep 29, 2024
@fkiraly fkiraly mentioned this issue Sep 29, 2024
Merged
fkiraly added a commit that referenced this issue Sep 29, 2024
@fkiraly
[MNT] experimental python 3.13 wheels and 3.13-rc.2 testing (#365)
e66d01d 
Adds experimental 3.13 wheels and testing on 3.13-rc.2, ahead of the
3.13 release early Oct 2024.

Full 3.13 support should be released with 0.11.0 only.

Towards #367
@fkiraly
Copy link
Contributor Author

fkiraly commented Oct 8, 2024

FYI @MCRE-BE

Thanks for taking care of the conda feedstock!

Just to let you know that for 0.11.0 we need to update the python bounds.

@MCRE-BE
Copy link

MCRE-BE commented Oct 9, 2024

No problem. I'll push the changes.

MCRE-BE added a commit to regro-cf-autotick-bot/skbase-suite-feedstock that referenced this issue Oct 9, 2024
@MCRE-BE
[CHORE] Bump Python version
edd4bf9 
Requested in sktime/skbase#367
@MCRE-BE
Copy link

MCRE-BE commented Oct 9, 2024

Should be fine.

@fkiraly
Copy link
Contributor Author

fkiraly commented Oct 9, 2024

Great - we can close 3.13 then.

@fkiraly fkiraly closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fkiraly @MCRE-BE