Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] correct parameter name in TestAllObjects all_objects call #236

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

fkiraly
Copy link
Contributor

@fkiraly fkiraly commented Oct 15, 2023

This corrects the parameter name in TestAllObjects all_objects call, from exclude_estimators to exclude_objects.

@fkiraly fkiraly added the bug Something isn't working label Oct 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1b5d4a8) 83.55% compared to head (225c1b0) 83.55%.
Report is 7 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #236   +/-   ##
=======================================
  Coverage   83.55%   83.55%           
=======================================
  Files          41       41           
  Lines        2833     2833           
=======================================
  Hits         2367     2367           
  Misses        466      466           
Files Coverage Δ
skbase/testing/test_all_objects.py 79.43% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fkiraly fkiraly merged commit 8b09e7f into main Oct 15, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants