-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] improved deep_equals
utility - plugins for custom types
#238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
… into deep_equals-improved
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…base into deep_equals-improved-2
for more information, see https://pre-commit.ci
…base into deep_equals-improved-2
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
==========================================
+ Coverage 83.72% 84.18% +0.45%
==========================================
Files 41 43 +2
Lines 2857 2889 +32
==========================================
+ Hits 2392 2432 +40
+ Misses 465 457 -8
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the
deep_equals
utility by introducing the ability to provide custom plugins.Ultimately, this enables more flexibility in soft dependencies for data containers such as
polars
(see, e.g., sktime/sktime#5423) throughout thesktime
package ecosystem, asdeep_equals
is used for extrinsic testing and validity checking.Similarly, the
ForecastingHorizon
check should be moved as a plugin intosktime
.In addition, makes the following changes:
deep_equals
file into a module with multiple filesDepends on #239.