Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] address readthedocs build failures #242

Merged
merged 2 commits into from
Oct 26, 2023
Merged

[ENH] address readthedocs build failures #242

merged 2 commits into from
Oct 26, 2023

Conversation

fkiraly
Copy link
Contributor

@fkiraly fkiraly commented Oct 26, 2023

This PR solves the readthedocs build issue by:

  • isolating some numpy imports
  • adding the test dep set as required for readthedocs builds to avoid import failures (pytest)

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e2271b5) 84.18% compared to head (9175e4a) 84.19%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
+ Coverage   84.18%   84.19%   +0.01%     
==========================================
  Files          43       43              
  Lines        2889     2891       +2     
==========================================
+ Hits         2432     2434       +2     
  Misses        457      457              
Files Coverage Δ
skbase/utils/tests/test_check.py 100.00% <100.00%> (ø)
skbase/utils/tests/test_deep_equals.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fkiraly fkiraly changed the title [ENH] isolate numpy imports [ENH] address readthedocs build failures Oct 26, 2023
@fkiraly fkiraly merged commit 12a1884 into main Oct 26, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants