[DOC] docstring with mathematical description for QPD_Empirical
#255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a mathematical description in the docstring of
QPD_Empirical
.The docstring also explains why the distribution is quantile parameterized, and its relation to
Empirical
.A review would be appreciated, @Ram0nB, @setoguchi-naoki, @FelixWick - I also hope (and would appreciate a check) for typos in the math.
FYI @VascoSch92, as this is an example where two formal objects:
and the more general question what the class/design principle should be here. Compare
Fibonacci
vsOEIS(n)
object. Also relates to the "multiple names" discussion in VascoSch92/sequentium#49, I am currently of the opinion that different class names should imply difference in parametric object.