Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] differential testing - handle non-package changes in pyproject.toml #472

Merged
merged 1 commit into from
Sep 29, 2024
Merged

[MNT] differential testing - handle non-package changes in pyproject.toml #472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions skpro/utils/git_diff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ def _get_packages_with_changed_specs():
-------
tuple of str : names of packages with changed or added specs
"""
from packaging.requirements import Requirement
from packaging.requirements import InvalidRequirement, Requirement

changed_lines = get_changed_lines("pyproject.toml")

Expand All @@ -175,8 +175,12 @@ def _get_packages_with_changed_specs():
if ";" in req:
req = req.split(";")[0]

pkg = Requirement(req).name
packages.append(pkg)
try: # deal with lines that are not package requirement strings
pkg = Requirement(req).name
except InvalidRequirement:
continue
else:
packages.append(pkg)

# make unique
packages = tuple(set(packages))
Expand Down
Loading