Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] in docstring, rename Example to Examples sections #7341

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Oct 27, 2024

It seems that examples in a docstring section with title Example are not displayed by sphinx, the name needs to be Examples.

This PR corrects the section header in a number of docstrings.

yarnabrina
yarnabrina previously approved these changes Oct 27, 2024
Copy link
Member

@yarnabrina yarnabrina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I want to note that few of these classes are missing from hosted docs, at least based on searching class names in search area of this PR docs page.

If it's intentional, please ignore. But missing ones include Vecm, probability distributions, etc.

@fkiraly
Copy link
Collaborator Author

fkiraly commented Oct 27, 2024

I see - VECM is an oversight, and distributions are intentionally not displayed as they are moving to skpro. But this may imply we have the same issue there.

@fkiraly
Copy link
Collaborator Author

fkiraly commented Oct 27, 2024

Yes, same issue has propagated in skpro, fixed now: sktime/skpro#487

@yarnabrina yarnabrina merged commit 1cdcb74 into main Oct 29, 2024
228 checks passed
@yarnabrina yarnabrina deleted the examples branch October 29, 2024 14:47
fkiraly added a commit to sktime/skpro that referenced this pull request Nov 3, 2024
It seems that examples in a docstring section with title `Example` are
not displayed by sphinx, the name needs to be `Examples`.

This PR corrects the section header in a number of docstrings.

Mirror of sktime/sktime#7341 in `sktime`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation & tutorials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants