Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for the Containerfile does not attempt to use skstat/skmanage, misses issues with Proton Python install #925

Closed
jiridanek opened this issue Jan 31, 2023 · 3 comments · Fixed by #1060
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jiridanek
Copy link
Contributor

$ docker run --name router -itd --rm quay.io/skupper/skupper-router:main
196e2784d48f4e597cf0057e9daca88d6a88c375d75f62fb98959e935308b6db
$ docker exec router skstat -l
Traceback (most recent call last):
  File "/usr/bin/skstat", line 29, in <module>
    from skupper_router.management.client import Node
  File "/usr/lib/python3.9/site-packages/skupper_router/management/client.py", line 22, in <module>
    import proton
ModuleNotFoundError: No module named 'proton'

Reported by @fgiorgetti

@jiridanek jiridanek added this to the 2.3.0 milestone Jan 31, 2023
@jiridanek jiridanek self-assigned this Jan 31, 2023
jiridanek added a commit to jiridanek/skupper-router that referenced this issue Jan 31, 2023
jiridanek added a commit that referenced this issue Feb 1, 2023
)

The SYSINSTALL option for Proton stopped working on main. Python package needs to be used.

I either need to copy the tar.gz from the build container to the run container and install it there, or I need to install the tar.gz in the build container under --prefix.

This PR does the latter.
@ganeshmurthy ganeshmurthy modified the milestones: 2.3.0, 2.4.0 Feb 6, 2023
ganeshmurthy added a commit that referenced this issue Feb 6, 2023
@ganeshmurthy
Copy link
Contributor

@jiridanek this issue seems to have been fixed by you already. Close this issue ?

@jiridanek
Copy link
Contributor Author

@ganeshmurthy The job still does not check that skstat/skmanage run, so there is more work to do. (They do run now, but it is not tested there.)

@jiridanek
Copy link
Contributor Author

One additional problem; the test does not wait for router to start and open port, so if it starts slowly, test fails. This is also something to be solved here.

See HEALTHCHECK Containerfile instruction, https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/building_running_and_managing_containers/assembly_monitoring-containers_building-running-and-managing-containers#performing-a-health-check-using-a-containerfile_assembly_monitoring-containers

Healthcheck feature is present in the router, 1e22255 hopefully it does what I need it to do (claim Healthy only when all listeners declared in config were opened).

@ganeshmurthy ganeshmurthy modified the milestones: 2.4.0, 2.5.0 Apr 12, 2023
@jiridanek jiridanek linked a pull request Apr 19, 2023 that will close this issue
@ganeshmurthy ganeshmurthy added the enhancement New feature or request label May 23, 2023
@ganeshmurthy ganeshmurthy added this to the 2.5.0 milestone May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants