Issue #48 - Make libwebsockets and libnghttp2 mandatory #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiridanek
added
the
P3
jiridanek
commented
Apr 29, 2022
jiridanek
commented
Apr 29, 2022
jiridanek
force-pushed
the
jd_2022_04_29_mandatory
branch
from
af494d3 to
8998309
Compare
jiridanek
requested review from
kgiusti and
ganeshmurthy
and removed request for
kgiusti
jiridanek
force-pushed
the
jd_2022_04_29_mandatory
branch
from
8998309 to
2e7c5a2
Compare
Codecov Report
@@ Coverage Diff @@
## main #397 +/- ##
=======================================
Coverage 25.14% 25.14%
=======================================
Files 115 115
Lines 28792 28792
Branches 4673 4673
=======================================
Hits 7241 7241
Misses 20581 20581
Partials 970 970
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Please take a look at my other comments in this PR. Once those are addressed, this is ready to merge |
I don't see any other comments from you besides this one, on #397 |
ganeshmurthy
requested changes
May 31, 2022
jiridanek
force-pushed
the
jd_2022_04_29_mandatory
branch
from
2e7c5a2 to
049113f
Compare
ganeshmurthy
approved these changes
Jun 1, 2022
jiridanek
force-pushed
the
jd_2022_04_29_mandatory
branch
from
049113f to
6f54255
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Router does not make sense without websockets or http2 support, so let's not permit such build.
This does not (yet) help with one remaining special libwebsockets case, but I believe this is just a matter of time.
skupper-router/python/skupper_router_site.py.in
Lines 50 to 51 in 96730e8
Thanks to embedding libwebsockets in the container build, the only thing holding it back are distribution packages, and Ubuntu 22.04 is on the way to CIs near you!