Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #475: never put non-debug code in an assert() #476

Merged
merged 1 commit into from
May 17, 2022

Conversation

kgiusti
Copy link
Contributor

@kgiusti kgiusti commented May 17, 2022

No description provided.

@kgiusti kgiusti requested a review from jiridanek May 17, 2022 13:39
@kgiusti kgiusti linked an issue May 17, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #476 (0f9625f) into main (e43f50f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #476   +/-   ##
=======================================
  Coverage   25.04%   25.04%           
=======================================
  Files         114      114           
  Lines       28609    28609           
  Branches     4646     4646           
=======================================
  Hits         7165     7165           
  Misses      20487    20487           
  Partials      957      957           
Flag Coverage Δ
unittests 25.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e43f50f...0f9625f. Read the comment docs.

Copy link
Contributor

@jiridanek jiridanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

: facepalm :, I thought I fixed this long time ago, and I did, but it's only as a commit in unmerged PR which I forgot actually carries anything urgent, cf2bd76 :( sorry about that

@kgiusti
Copy link
Contributor Author

kgiusti commented May 17, 2022

No sweat - there isn't a C programmer worth their salt that hasn't been bit by this one!

@kgiusti kgiusti merged commit bf92c97 into skupperproject:main May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

c-benchmark crashes on uninitialized pointer
3 participants