Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #840: Set timeout on Node.connect to TIMEOUT #841

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Fixes #840: Set timeout on Node.connect to TIMEOUT #841

merged 1 commit into from
Nov 7, 2022

Conversation

ganeshmurthy
Copy link
Contributor

No description provided.

@ganeshmurthy
Copy link
Contributor Author

Setting the timeout on Node.connect to TIMEOUT seems to resolve this issue

@jiridanek jiridanek linked an issue Nov 5, 2022 that may be closed by this pull request
system_tests_user_id failure with timeout #840
Closed
@jiridanek
Copy link
Contributor

Setting the timeout on Node.connect to TIMEOUT seems to resolve this issue

The default timeout is 10 and the new timeout (of TIMEOUT) is 60 by default, and in CI it is QPID_SYSTEM_TEST_TIMEOUT: 300.

jiridanek
jiridanek approved these changes Nov 5, 2022
View reviewed changes
Copy link
Contributor

@jiridanek jiridanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels strange that 10s is not enough, but considering the overhead from -j2/j6 and sanitizers, I guess this is actually reasonable.

@ganeshmurthy ganeshmurthy merged commit 849061c into skupperproject:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiridanek jiridanek jiridanek approved these changes

@kgiusti kgiusti Awaiting requested review from kgiusti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

system_tests_user_id failure with timeout
2 participants
@ganeshmurthy @jiridanek