Skip to content

fix: address some static code analysis issues, exposed by the latest … #14

fix: address some static code analysis issues, exposed by the latest …

fix: address some static code analysis issues, exposed by the latest … #14

Re-run triggered November 18, 2023 20:58
Status Failure
Total duration 3m 58s
Artifacts 2

main.yml

on: push
determine-version
10s
determine-version
build (v4.2.1-ci.1+3)
1m 53s
build (v4.2.1-ci.1+3)
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

1 error and 10 warnings
test (macos-latest)
Process completed with exit code 1.
build (v4.2.1-ci.1+3): src/MockHttp/Responses/IResponseBehavior.cs#L7
Rename type name ResponseHandlerDelegate so that it does not end in 'Delegate' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
build (v4.2.1-ci.1+3): src/MockHttp/Responses/IResponseBehavior.cs#L22
In virtual/interface member IResponseBehavior.HandleAsync(MockHttpRequestContext, HttpResponseMessage, ResponseHandlerDelegate, CancellationToken), rename parameter next so that it no longer conflicts with the reserved language keyword 'Next'. Using a reserved keyword as the name of a parameter on a virtual/interface member makes it harder for consumers in other languages to override/implement the member. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1716)
build (v4.2.1-ci.1+3): src/MockHttp/Matchers/HttpHeadersMatcher.cs#L114
'string.Replace(string, string)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'MockHttp.Matchers.HttpHeadersMatcher.ToString()' with a call to 'string.Replace(string, string, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
build (v4.2.1-ci.1+3): src/MockHttp/Responses/IResponseBehavior.cs#L7
Rename type name ResponseHandlerDelegate so that it does not end in 'Delegate' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
build (v4.2.1-ci.1+3): src/MockHttp/Responses/IResponseBehavior.cs#L22
In virtual/interface member IResponseBehavior.HandleAsync(MockHttpRequestContext, HttpResponseMessage, ResponseHandlerDelegate, CancellationToken), rename parameter next so that it no longer conflicts with the reserved language keyword 'Next'. Using a reserved keyword as the name of a parameter on a virtual/interface member makes it harder for consumers in other languages to override/implement the member. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1716)
build (v4.2.1-ci.1+3): src/MockHttp/Http/DataEscapingHelper.cs#L53
'string.Replace(string, string?)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'MockHttp.Http.DataEscapingHelper.UnescapeData(string)' with a call to 'string.Replace(string, string?, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
build (v4.2.1-ci.1+3): src/MockHttp/Responses/IResponseBehavior.cs#L7
Rename type name ResponseHandlerDelegate so that it does not end in 'Delegate' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
build (v4.2.1-ci.1+3): src/MockHttp/Responses/IResponseBehavior.cs#L22
In virtual/interface member IResponseBehavior.HandleAsync(MockHttpRequestContext, HttpResponseMessage, ResponseHandlerDelegate, CancellationToken), rename parameter next so that it no longer conflicts with the reserved language keyword 'Next'. Using a reserved keyword as the name of a parameter on a virtual/interface member makes it harder for consumers in other languages to override/implement the member. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1716)
build (v4.2.1-ci.1+3): src/MockHttp/Responses/IResponseBehavior.cs#L7
Rename type name ResponseHandlerDelegate so that it does not end in 'Delegate' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
build (v4.2.1-ci.1+3): src/MockHttp/HttpMockException.cs#L39
Provide a message for the ObsoleteAttribute that marks .ctor as Obsolete (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1041)

Artifacts

Produced during runtime
Name Size
build Expired
66.4 MB
release-4.2.1-ci.1+3 Expired
999 KB