Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CA1031): use exception handler middleware instead of catching all exceptions in ServerRequestHandler #105

Merged
merged 1 commit into from
Feb 3, 2024
Merged

fix(CA1031): use exception handler middleware instead of catching all exceptions in ServerRequestHandler #105

merged 1 commit into from
Feb 3, 2024

Conversation

skwasjer
Copy link
Owner

@skwasjer skwasjer commented Feb 3, 2024 •
edited
Loading

Fix CA1031 warning. This also avoids unnecessary allocation of new HttpResponseMessage.

@skwasjer skwasjer enabled auto-merge (squash) February 3, 2024 17:15
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

84.0% Coverage on New Code (required ≥ 85%)

See analysis details on SonarCloud

@skwasjer skwasjer disabled auto-merge February 3, 2024 17:20
@skwasjer skwasjer merged commit fbb371a into main Feb 3, 2024
9 of 11 checks passed
@skwasjer skwasjer deleted the bugfix/CA1031 branch February 3, 2024 17:21
@skwasjer skwasjer added the enhancement New feature or request label Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@skwasjer