Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(xml): do not modify XmlSettings supplied to XmlBody. #90

Merged
merged 1 commit into from
Nov 21, 2023
Merged

fix(xml): do not modify XmlSettings supplied to XmlBody. #90

merged 1 commit into from
Nov 21, 2023

Conversation

skwasjer
Copy link
Owner

@skwasjer skwasjer commented Nov 19, 2023 •
edited
Loading

The XmlBody previously modified the supplied XmlSettings instance. Instead, now it is cloned before modification.

@skwasjer skwasjer enabled auto-merge (squash) November 19, 2023 03:44
@skwasjer skwasjer force-pushed the fix/do_not_modify_original_xml_settings branch from eeefdf6 to 1098129 Compare November 19, 2023 16:23
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@skwasjer skwasjer disabled auto-merge November 21, 2023 22:32
@skwasjer skwasjer enabled auto-merge (squash) November 21, 2023 22:32
@skwasjer skwasjer merged commit c409ba3 into main Nov 21, 2023
13 checks passed
@skwasjer skwasjer deleted the fix/do_not_modify_original_xml_settings branch November 21, 2023 22:37
@skwasjer skwasjer added the bug Something isn't working label Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@skwasjer