add ability to encode header entries #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add encodeHeader function to template * update template to encode subject and tag in mail header * add documentation to template * adjust test for changed template
|
This seems reasonable, and useful,, at a quick glance. I'll test and merge in a day or two, but busy here just now. Thanks for your contribution :) |
|
This breaks the format of non-atom feed subjects for me. https://aws.amazon.com/about-aws/whats-new/recent/feed/ 
Any ideas? Thanks in advance! |
|
Confirmed, I see the same thing. If there's no update from @thoka within the next week I'll have to revert, and see if there is a middle-ground. |
|
Hm. quotedprintable inserts soft line breaks (=\r\n), when line length exceeds 76 chars Fixed in thoka@39de2c7 |
|
Thanks @thoka. I can confirm that the fix works. |
|
Applied now, and released as release-3.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encode subject, if a feed contains non-ASCII characters.