Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to uniquify feed items with duplicate URLS #120

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

skx
Copy link
Owner

@skx skx commented Dec 5, 2023

This pull-request should close #111 once complete, but I admit I haven't tested it yet.

This pull-request should close #111 once complete, but I admit
I haven't tested it yet.
@StayPirate
Copy link
Contributor

Sorry for the delay, I was AFK due to illness. I just ran it with --send=false and over ~160 feeds it retrieved a few hundred new items previously shadowed behind the same URL. I'll now let it run for 24h to see how it behaves, then report my feedback.

@StayPirate
Copy link
Contributor

It's been running for a couple of days and I would say that it is behaving as expected. LGTM

@skx
Copy link
Owner Author

skx commented Dec 13, 2023

No worries, bug-reports and updates are always "best effort", and I assume people will disappear for days/weeks at a time.

Thanks for confirming it looks good. I'll merge soon.

@skx skx merged commit 071ad1c into master Dec 15, 2023
3 checks passed
@skx skx deleted the 111-avoid-dupes branch December 15, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The link attribute in a feed might not be unique, relying only on that to identify entries is not enough
2 participants