Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #122 we updated our codebase to ensure that we used a common logging handle to send our output messages to the user:
This pull-request builds upon that work to write the log messages to a file, as well as showing them to the user. By default a file
rss2email.log
is generated when the application starts and log entries are appended to it.However:
Why do this? Partly for reference, but also partly to allow a local setup to view errors.
We could now resolve #119 by adding a cronjob:
(Of course this might not work 100% as the current approach assumes the file is open forever in the case of
daemon
sub-command.)This isn't a complete solution, but without getting into the whole template-customization and more complex considerations it's not a terrible thing to do.