Do not trigger daily image rebuild #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daily recreate the image even there's no changes in the code is quite inconvenient and a waste of resources. It is inconvenient for processes that daily monitor for image updates (I do that) and automatically update containers every time a new image is detected. In my case rss2emails container image is automatically pulled every day and the local container recreated, even if there are no changes in the code. I think it is safe to remove the scheduled trigger because this GH action is equipped with other more reasonable triggers: * For each commit in master branch * For new pushed tag in the form of v*.*.* * For PR against the master branch
StayPirate
changed the title
|
Sorry somehow I missed this; merged with thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Daily build the container image, even when there's no changes in the code, is quite inconvenient and a waste of resources. It is inconvenient for processes that daily monitor for container image updates (I do that), automatically pull and update containers every time a new image is detected.
I think it is safe to remove the schedule-trigger because the GH action is equipped with other more reasonable triggers: