Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamed pypi-description.rst to PKG-INFO. #93

Merged
merged 2 commits into from
Nov 28, 2018
Merged

renamed pypi-description.rst to PKG-INFO. #93

merged 2 commits into from
Nov 28, 2018

Conversation

ibegleris
Copy link
Contributor

Bug #92 tracked to: Pypi-description.rst being renamed in python3 to PKG-INFO.

I simply renamed the file in the repository and made sure setup.py reads the correct file.

Local tests on installing show that Python 2.7 and 3.6 work with this fix.

@codecov-io
Copy link

codecov-io commented Nov 28, 2018

Codecov Report

Merging #93 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #93   +/-   ##
=======================================
  Coverage   84.89%   84.89%           
=======================================
  Files           6        6           
  Lines        1377     1377           
=======================================
  Hits         1169     1169           
  Misses        208      208

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2173abc...8394470. Read the comment docs.

@capelastegui
Copy link
Contributor

Pushed release to test.pypi, installed successfully on python 2 and 3. Merging and creating new release.

@capelastegui capelastegui merged commit d27b076 into master Nov 28, 2018
@capelastegui capelastegui deleted the hotfix_92 branch November 28, 2018 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants