Fix test assertion to be called. Fix array equality test for headers. #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mishamo
commented
Jan 6, 2021
| publish(schedules) andThen | ||
| (assertMessagesWrittenFrom(_, schedules)) | ||
| publish(schedules) | ||
| .foreach(assertMessagesWrittenFrom(_, schedules)) |
There was a problem hiding this comment.
The andThen returns a partial function which was never actually called, so the assertion never got executed.
mishamo
commented
Jan 6, 2021
| cr.headers().toArray.map(h => h.key() -> h.value()).toMap should contain theSameElementsAs schedule.headers | ||
| cr.headers().toArray.map(h => h.key() -> h.value().toList) should contain theSameElementsAs | ||
| schedule.headers.map { | ||
| case (k, v) => (k, v.toList) |
There was a problem hiding this comment.
Due to the values being Array[Byte], the equality test would always fail, even if they were equivalent (due to array equality basically being rubbish in scala).
mishamo
commented
Jan 6, 2021
| @@ -8,7 +8,7 @@ import scala.concurrent.duration._ | |||
|
|
|||
| package object e2e { | |||
|
|
|||
| val Tolerance = 200 millis | |||
| val Tolerance = 400 millis | |||
There was a problem hiding this comment.
With the assertion enabled, I found the test to be flaky with values under 400 millis
mishamo
commented
Jan 6, 2021
| @@ -48,7 +49,10 @@ class SchedulerIntSpec extends SchedulerIntSpecBase { | |||
| cr.key should contain theSameElementsInOrderAs schedule.key | |||
| cr.value should contain theSameElementsInOrderAs schedule.value.get | |||
There was a problem hiding this comment.
As random[ScheduledEvent] can generate the value field as None around 10% of the time, it causes the right hand side of this test to fail. Investigating a possible fix for this.
Fix assertion to handle empty Option.
mishamo
force-pushed
the
fix-test-assertion
branch
from
00cdf54
to
a001128
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.