Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actively catching terminal resize. #44

Merged
merged 1 commit into from
Jun 8, 2018

Conversation

edupo
Copy link

@edupo edupo commented Apr 8, 2018

autoResizeContainer uses resizeContainer after the SIGWINCH signal.

@lucymhdavies
Copy link

lucymhdavies commented Apr 8, 2018

Looks great!

Resolves #26

Could you rebase, to pick up some of the static analysis fixes (make sure Travis isn't picking up something already fixed), and add something to CHANGELOG.md.

Otherwise, I'm happy to merge this. 👍

@edupo
Copy link
Author

edupo commented Apr 12, 2018

Sure, I'll try to rebase this weekend ;)

@lucymhdavies lucymhdavies added this to the v0.3.0 milestone Apr 13, 2018
@edupo
Copy link
Author

edupo commented Jun 5, 2018

It has been a long time! I had no time to work on this.

@edupo edupo force-pushed the 26/resize-tty branch 2 times, most recently from 0d136b1 to 7e5af55 Compare June 5, 2018 07:03
lucymhdavies pushed a commit to lucymhdavies/cali that referenced this pull request Jun 8, 2018
@lucymhdavies lucymhdavies merged commit 7e5af55 into skybet:master Jun 8, 2018
@lucymhdavies lucymhdavies modified the milestones: v0.3.0, v0.4.0 Jun 8, 2018
@lucymhdavies lucymhdavies mentioned this pull request Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants