-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature | Server Type #245
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tication for recognize official dmsg servers - update dmsg server entry structure and add serverType value there, the value be `official` or `community`
please create a file which contains the dmsg servers to be whitelisted and include it. |
…s, separated by comma
No file, just simple string |
0pcom
approved these changes
Dec 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30
Changes:
--auth
flag to dmsg-discovery and dmsg-server, as simple authentication for recognize official dmsg servers--official-servers
flag as list of official dmsg-servers separated by comma,
serverType
field to*disc.Entry
as type of dmsg serverHow to test this PR:
run
redis-server
in default 6379 portbuild on this PR's branch
make build
run
dmsg-discovery
with--auth
flag as./bin/dmsg-discovery -t --auth 123
run a test dmsg-server with
--auth
flag and another without that flag as./bin/dmsg-server start ./integration/configs/dmsgserver1.json --auth 123
./bin/dmsg-server start ./integration/configs/dmsgserver2.json
check dmsg discovery's all server endpoint in http://localhost:9090/dmsg-discovery/all_servers
should be something like this:
run a test dmsg-server with
--official-servers
flag as./bin/dmsg-discovery -t --official-servers 0297347088626e5d6468bc0ed258f2a5e7a279fae48b3636275220611c2eb01321
run dmsg-servers without any flag as
./bin/dmsg-server start ./integration/configs/dmsgserver1.json
./bin/dmsg-server start ./integration/configs/dmsgserver2.json
check dmsg discovery's all server endpoint again
should be something like this
Note:
Old version of dmsg servers still available to register, but their type will set as
community