Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The curl library should be build in release mode for release versions #66

Open
stdevAlDen opened this issue May 26, 2019 · 0 comments
Open

The curl library should be build in release mode for release versions #66

stdevAlDen opened this issue May 26, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@stdevAlDen
Copy link

stdevAlDen commented May 26, 2019 •
edited
Loading

Describe the bug
The build type is hard coded.

Environment information:

  • Any

Steps to Reproduce
Just look at the code https://github.com/simelo/libskycoin/blob/3cb637dbd49eb3073d18b25205cc58e2519a28c7/lib/curl/CMakeLists.txt#L9

Actual behavior
The curl library is build in debug as unique option.

Expected behavior
Be able to set a predefined value via command line.

Additional context
It's very important to move on this if you regenerate the CMakeLists.txt file.
@stdevAlDen stdevAlDen added the bug Something isn't working label May 26, 2019
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 26, 2019
use CMAKE_BUILD_TYPE o debug as default value if none specified ref s…
6ee89a1 
…kycoin#66
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 26, 2019
build lib curl in release mode ref skycoin#66
29c7110
@stdevAlDen stdevAlDen mentioned this issue May 26, 2019
Merged
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 26, 2019
update changeslog ref skycoin#66
d304b68
@stdevAlDen stdevAlDen mentioned this issue May 26, 2019
Open
olemis added a commit to simelo/libskycoin.orig that referenced this issue Jun 12, 2019
@olemis
refs skycoin#66 - Minor fix in CHANGELOG
bf51ecd
@vidya88 vidya88 mentioned this issue Sep 20, 2019
Open
@isaacvr isaacvr mentioned this issue Oct 31, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stdevAlDen