Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Go18 #424

Merged
merged 7 commits into from
Apr 23, 2023
Merged

Update to Go18 #424

merged 7 commits into from
Apr 23, 2023

Conversation

Senyoret1
Copy link
Contributor

Fixes #423

Changes:

  • go.mod was added and the server should now work well with Go18.
  • The readme was updated.
  • The Travis file was updated to use the new Go version.

Does this change need to mentioned in CHANGELOG.md?
Yes

@Senyoret1
Copy link
Contributor Author

The last commit includes the following changes:

  • Now the Go server returns the correct mime type for JavaScript files, to make the app work well with modern brownser without an intermediate server.
  • Now there are CLI params to configure the web server address:port, the URL of the Skycoin node and the path of the folder with the precompiled UI files. Run “go run explorer.go -h” to see the param list.
  • The branch was updated.

@Senyoret1
Copy link
Contributor Author

The last commit replaces gometalinter with golangci-lint. It works similar to how it works on the Skycoin wallet. Also, some changes were made to make the tests pass.

@Senyoret1
Copy link
Contributor Author

The last commit inslcudes info in the readme and a new helper command 1n the makefile, for installing the linters in a local enviroment.

@0pcom 0pcom self-requested a review April 23, 2023 20:19
Copy link
Collaborator

@0pcom 0pcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks really good, nicely done

@0pcom 0pcom merged commit 5409e9a into skycoin:develop Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix dependencies
2 participants