Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[M2] Finish renaming to dmsg #526

Open
wants to merge 3 commits into
base: mainnet-milestone1
Choose a base branch
from
Open

[M2] Finish renaming to dmsg #526

wants to merge 3 commits into from

Conversation

nkryuchkov
Copy link
Collaborator

Closes #502

Copy of skycoin/skywire#512 for mainnet-milestone1 branch.

Done:

  • Rename messaging to dmsg

@nkryuchkov nkryuchkov mentioned this pull request Aug 22, 2019
Closed
evanlinjin
evanlinjin reviewed Aug 23, 2019
View reviewed changes
Copy link

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need an accompanying PR into skywire-services that ensures that interactive environment still compiles and runs as expected, as the renaming of binaries will cause issues.

@evanlinjin
Copy link

I have a change of mind. We should probably do this after all the other mainnet-milestone1 PRs are merged.

@evanlinjin evanlinjin mentioned this pull request Aug 28, 2019
Closed
@evanlinjin evanlinjin changed the title Finish renaming to dmsg [M2] Finish renaming to dmsg Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanlinjin evanlinjin evanlinjin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkryuchkov @evanlinjin