Fix memory plugin build #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyjson does not work with main packages. Workaround changing the package name as suggested in mailru/easyjson#236 Some code has been moved from skydive to graffity: common.Getter Clean and update gomod: k8s deps should be added with replace, kubernetes/kubernetes#79384 Same problem with networkservicemesh viper is not being used add skydive as dep, not local replace Once compiled it fails to run with skydive because problems with the Go plugin framework. The error is: plugin was built with a different version of package golang.org/x/sys/unix golang/go#20481 golang/go#27751 Tested adding to the skydive.yml config file: plugin: plugins_dir: /home/adrian/go/src/github.com/skydive-project/skydive-plugins/memory topology: probes: memory
|
Thanks for the fix, merging it as it is, we will adress the dep issue later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
easyjson does not work with main packages. Workaround changing the
package name as suggested in mailru/easyjson#236
Some code has been moved from skydive to graffity: common.Getter
Clean and update gomod:
k8s deps should be added with replace, kubernetes/kubernetes#79384
Same problem with networkservicemesh
viper is not being used
add skydive as dep, not local replace
Once compiled it fails to run with skydive because problems with the Go
plugin framework.
The error is: plugin was built with a different version of package golang.org/x/sys/unix
golang/go#20481
golang/go#27751
Tested adding to the skydive.yml config file:
plugin:
plugins_dir: /home/adrian/go/src/github.com/skydive-project/skydive-plugins/memory
topology:
probes: memory