Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setter for custom layout view instead of resource #59

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Setter for custom layout view instead of resource #59

merged 1 commit into from
Jun 10, 2020

Conversation

denis-ismailaj
Copy link
Contributor

Guidelines

This commit adds a method overload for setLayout from which the user can specify a programmatically created View instead of just inputting an XML layout resource.

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Preparing a pull request for review

./gradlew spotlessApply runs successfully.

@denis-ismailaj denis-ismailaj requested a review from skydoves as a code owner June 9, 2020 14:45
skydoves
skydoves approved these changes Jun 10, 2020
View reviewed changes
Copy link
Owner

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@skydoves skydoves merged commit 34d0b5a into skydoves:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skydoves skydoves skydoves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denis-ismailaj @skydoves