Merge pull request #12 from skydoves/updates/unbind

Unbind binding property when the lifecycle is on destroyed

bindables/src/main/java/com/skydoves/bindables/BindingActivity.kt

@@ -67,4 +67,13 @@ abstract class BindingActivity<T : ViewDataBinding> constructor(
       binding.notifyChange()
     }
   }
+
+  /**
+   * Removes binding listeners to expression variables and destroys the [binding] backing property for preventing
+   * leaking the [ViewDataBinding] that references the Context.
+   */
+  override fun onDestroy() {
+    super.onDestroy()
+    binding.unbind()
+  }
 }

bindables/src/main/java/com/skydoves/bindables/BindingBottomSheetDialogFragment.kt

@@ -86,6 +86,7 @@ abstract class BindingBottomSheetDialogFragment<T : ViewDataBinding> constructor
    */
   override fun onDestroyView() {
     super.onDestroyView()
+    _binding?.unbind()
     _binding = null
   }
 }

bindables/src/main/java/com/skydoves/bindables/BindingComponentActivity.kt

@@ -67,4 +67,13 @@ abstract class BindingComponentActivity<T : ViewDataBinding> constructor(
       binding.notifyChange()
     }
   }
+
+  /**
+   * Removes binding listeners to expression variables and destroys the [binding] backing property for preventing
+   * leaking the [ViewDataBinding] that references the Context.
+   */
+  override fun onDestroy() {
+    super.onDestroy()
+    binding.unbind()
+  }
 }

bindables/src/main/java/com/skydoves/bindables/BindingDialogFragment.kt

@@ -86,6 +86,7 @@ abstract class BindingDialogFragment<T : ViewDataBinding> constructor(
    */
   override fun onDestroyView() {
     super.onDestroyView()
+    _binding?.unbind()
     _binding = null
   }
 }

bindables/src/main/java/com/skydoves/bindables/BindingFragment.kt

@@ -86,6 +86,7 @@ abstract class BindingFragment<T : ViewDataBinding> constructor(
    */
   override fun onDestroyView() {
     super.onDestroyView()
+    _binding?.unbind()
     _binding = null
   }
 }

bindables/src/main/java/com/skydoves/bindables/BindingFragmentActivity.kt

@@ -67,4 +67,13 @@ abstract class BindingFragmentActivity<T : ViewDataBinding> constructor(
       binding.notifyChange()
     }
   }
+
+  /**
+   * Removes binding listeners to expression variables and destroys the [binding] backing property for preventing
+   * leaking the [ViewDataBinding] that references the Context.
+   */
+  override fun onDestroy() {
+    super.onDestroy()
+    binding.unbind()
+  }
 }

bindables/src/main/java/com/skydoves/bindables/BindingModel.kt

@@ -112,4 +112,14 @@ abstract class BindingModel : BindingObservable {
       propertyCallbacks.notifyCallbacks(this, BR._all, null)
     }
   }
+
+  /**
+   * Clears all binding properties from the callback registry.
+   */
+  override fun clearAllProperties() {
+    synchronized(lock) lock@{
+      val propertyCallbacks = propertyCallbacks ?: return@lock
+      propertyCallbacks.clear()
+    }
+  }
 }