Account for HOFSTR hardware flaw in h-bias worlds #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I double checked the behavior against level 3 of Wario Land. H-bias layers that are used for the wavy underwater effect still work. |
skyfloogle
reviewed
Mar 9, 2024
| @@ -374,7 +374,8 @@ void video_hard_render() { | |||
| } | |||
| } else { | |||
| // hbias or affine world | |||
| s16 *params = (s16 *)(&V810_DISPLAY_RAM.pmemory[0x20000 + windows[wnd * 16 + 9] * 2]); | |||
| u32 param_base = (u32)&V810_DISPLAY_RAM.pmemory[0x20000 + windows[wnd * 16 + 9] * 2]; | |||
There was a problem hiding this comment.
Is the cast to u32 necessary? It seems like this should be possible with just s16* indexing.
There was a problem hiding this comment.
I have to cast to an arithmetic type somewhere to determine alignment. I moved it down in #45 if you prefer that one instead.
There was a problem hiding this comment.
I prefer not casting a pointer to an integer where it's not absolutely needed, and storing param_base separately is a viable alternative. I'll merge this PR so you get the credit, and then tweak it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VB hardware will OR the eye "offset" with the param_base instead of adding it to compute the h-bias offset, which results in incorrect behavior if the param_base isn't word-aligned. See http://perfectkiosk.net/stsvb.html#vip_worlds_h_bias
Another selfish fix for Elevated Speed, which exploits this flaw to reduce writes to VRAM