Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move phdi customizations into fork #3

Merged
merged 30 commits into from
Nov 7, 2024
Merged

Move phdi customizations into fork #3

merged 30 commits into from
Nov 7, 2024

Conversation

mcmcgrath13
Copy link
Member

@mcmcgrath13 mcmcgrath13 commented Nov 1, 2024 •
edited
Loading

Make the fork here the source of truth for customizations needed for phdi.

  • Move all templates here
  • Move custom filters and tests
  • Move loinc and rxnorm codes
  • Update .gitignore for common usage
  • Add skylight to the license file and remove the linting around the header license statement

@mcmcgrath13 mcmcgrath13 changed the title Mcm/customize Move phdi customizations into fork Nov 1, 2024
@mcmcgrath13 mcmcgrath13 mentioned this pull request Nov 4, 2024
Merged
1 task
@mcmcgrath13 mcmcgrath13 marked this pull request as ready for review November 4, 2024 11:43
BobanL
BobanL reviewed Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments on the files that aren't in the data/Template folder 😅 .

src/Microsoft.Health.Fhir.Liquid.Converter.Tool/Program.cs Show resolved Hide resolved
src/Microsoft.Health.Fhir.Liquid.Converter.Tool/ConverterLogicHandler.cs Outdated Show resolved Hide resolved
src/Microsoft.Health.Fhir.Liquid.Converter/Filters/CustomFilters.cs Show resolved Hide resolved
BobanL
BobanL approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works exactly as expected! Thanks for your work on this 😄

robertmitchellv
robertmitchellv approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@robertmitchellv robertmitchellv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this; i think it's great to put custom templates here and i don't see anything out of place 🚀

@mcmcgrath13 mcmcgrath13 merged commit feb01c1 into main Nov 7, 2024
2 checks passed
@mcmcgrath13 mcmcgrath13 deleted the mcm/customize branch November 7, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BobanL BobanL BobanL approved these changes

@robertmitchellv robertmitchellv robertmitchellv approved these changes

@austin-hall-skylight austin-hall-skylight Awaiting requested review from austin-hall-skylight

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcmcgrath13 @robertmitchellv @BobanL @pallar-ms