disable OK-checking on custom http verbs

skylightio · Oct 17, 2022 · fc18625 · fc18625
1 parent 311f093
commit fc18625
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/spec/integration/probes/httpclient_spec.rb b/spec/integration/probes/httpclient_spec.rb
@@ -93,7 +93,8 @@ def server_uri
 
     response = client.request("CUSTOM", uri)
     expect(response).to be_a(HTTP::Message)
-    expect(response).to be_ok
+    # Later versions of puma (>= 6) hardcode this to return a 501 response.
+    # expect(response).to be_ok
   end
 
   it "instruments HTTPClient.methodname static methods" do

diff --git a/spec/integration/probes/net_http_spec.rb b/spec/integration/probes/net_http_spec.rb
@@ -162,9 +162,10 @@ def server_uri
     expect(Skylight).to receive(:instrument).with(expected).and_call_original
 
     http = Net::HTTP.new("127.0.0.1", port)
-    response = http.request(CustomType.new("/test.html"))
+    http.request(CustomType.new("/test.html"))
 
-    expect(response).to be_a(Net::HTTPOK)
+    # later versions of puma hardcode an error response here (501)
+    # expect(response).to be_a(Net::HTTPOK)
   end
 
   it "instruments basic auth" do