fix(quark): fix automated installation and check exit code of execute…

…d external commands (#2119)(PR #2216)
skylot · Jul 12, 2024 · 366225f · 366225f
1 parent 730db0d
commit 366225f
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/jadx-gui/src/main/java/jadx/gui/plugins/quark/QuarkManager.java b/jadx-gui/src/main/java/jadx/gui/plugins/quark/QuarkManager.java
@@ -151,6 +151,7 @@ private void installQuark() {
 		List<String> cmd = new ArrayList<>();
 		cmd.add(getCommand("pip3"));
 		cmd.add("install");
+		cmd.add("setuptools");
 		cmd.add("quark-engine");
 		cmd.add("--upgrade");
 		try {
@@ -213,6 +214,10 @@ private void runCommand(List<String> cmd) throws Exception {
 		} finally {
 			process.waitFor();
 		}
+		if (process.exitValue() != 0) {
+			throw new RuntimeException("Execution failed (exit code " + process.exitValue() + ") - command "
+					+ String.join(" ", cmd) + "\nPlease see command log output what was going wrong.");
+		}
 	}
 
 	private boolean checkCommand(String... cmd) {